[checkpoint] Update kv split for checkpoint #15745
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash-darin
changed the title
andrewkroh
added
Integration:checkpoint
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
Contributor
taylor-swanson
left a comment
taylor-swanson
left a comment
There was a problem hiding this comment.
Could you add a pipeline test to verify the change behaves correctly?
Additionally, the version in manifest.yml needs to be updated to match the changelog (1.41.3)
Add a simplified test case
removed a space that crept in at the wrong location
Contributor
Author
|
@taylor-swanson I updated the changelog and added a test case in a hopefully sufficient way, as I shortened it considerably. The original message with all the headers would have been 24kb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
Proposed commit message
This uses a more complex Regex to split the KV pairs in the Checkpoint message.
This is necessary if you use it to process email, as the headers might contain strings of the form:
X-IronPort-AV: E=Sophos;i=\\\"8.18,219,1756234400\\\"; d=\\\"png"; SophosThe original regex would regeard both examples as a split, when in reality they are not. Use (negative) lookbehind to box the kv split parameter in.
(?<!\\")(?<="); (?=\w)lookbehind:
(?<=")react to";but
negative lookbehind:
(?<!\\")do not react to\";lookahead:
(?=\w)expect a character after 1 (one) space:; abcdChecklist
changelog.ymlfile.How to test this PR locally
Check your logs/indices if any messages are rejected. Apply fix and check whether numbers go down..